[PATCH] D72310: [mlir][VectorOps] Implement strided_slice conversion

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:736
+       it != eit; ++it)
+    res.push_back((*it).getValue().getSExtValue());
+  return res;
----------------
ftynse wrote:
> Would `it->getValue()` work ?
Unfortunately no, it hits the following error:
```
llvm/include/llvm/ADT/iterator.h:169:34: error: taking the address of a temporary object of type 'mlir::IntegerAttr' [-Waddress-of-temporary]
  PointerT operator->() { return &static_cast<DerivedT *>(this)->operator*(); }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72310/new/

https://reviews.llvm.org/D72310