[PATCH] D72429: [mlir] Change the syntax of AffineMapAttr and IntegerSetAttr to avoid conflicts with function types.

[River Riddle via Phabricator via llvm-commits]

rriddle created this revision.
rriddle added reviewers: bondhugula, nicolasvasilache, andydavis1, jpienaar.
Herald added subscribers: llvm-commits, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, burmako, mehdi_amini, arphaman, zzheng.
Herald added a reviewer: mravishankar.
Herald added a reviewer: antiagainst.
Herald added 1 blocking reviewer(s): nicolasvasilache.
Herald added a project: LLVM.

The current syntax for AffineMapAttr and IntegerSetAttr conflict with function types, making it currently impossible to round-trip function types(and e.g. FuncOp) in the IR. This revision changes the syntax for the attributes by wrapping them in a keyword. AffineMapAttr is wrapped with `affine_map<>` and IntegerSetAttr is wrapped with `affine_set<>`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72429

Files:
  mlir/docs/Dialects/Affine.md
  mlir/docs/LangRef.md
  mlir/include/mlir/IR/OpImplementation.h
  mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
  mlir/lib/IR/AsmPrinter.cpp
  mlir/lib/Parser/Parser.cpp
  mlir/lib/Parser/TokenKinds.def
  mlir/test/AffineOps/canonicalize.mlir
  mlir/test/AffineOps/dma.mlir
  mlir/test/AffineOps/inlining.mlir
  mlir/test/AffineOps/invalid.mlir
  mlir/test/AffineOps/load-store-invalid.mlir
  mlir/test/AffineOps/load-store.mlir
  mlir/test/AffineOps/memref-stride-calculation.mlir
  mlir/test/AffineOps/ops.mlir
  mlir/test/Conversion/StandardToLLVM/convert-memref-ops.mlir
  mlir/test/Conversion/StandardToLLVM/convert-to-llvmir.mlir
  mlir/test/Conversion/StandardToLLVM/standard-to-llvm.mlir
  mlir/test/Conversion/VectorToLoops/vector-to-loops.mlir
  mlir/test/Dialect/Linalg/fusion.mlir
  mlir/test/Dialect/Linalg/invalid.mlir
  mlir/test/Dialect/Linalg/llvm.mlir
  mlir/test/Dialect/Linalg/loops.mlir
  mlir/test/Dialect/Linalg/promote.mlir
  mlir/test/Dialect/Linalg/roundtrip.mlir
  mlir/test/Dialect/Linalg/tile.mlir
  mlir/test/Dialect/Linalg/tile_conv.mlir
  mlir/test/Dialect/Linalg/tile_indexed_generic.mlir
  mlir/test/Dialect/Linalg/transform-patterns.mlir
  mlir/test/Dialect/SPIRV/composite-ops.mlir
  mlir/test/Dialect/VectorOps/invalid.mlir
  mlir/test/Dialect/VectorOps/ops.mlir
  mlir/test/Dialect/VectorOps/vector-transforms.mlir
  mlir/test/EDSC/builder-api-test.cpp
  mlir/test/IR/affine-map.mlir
  mlir/test/IR/core-ops.mlir
  mlir/test/IR/invalid-affinemap.mlir
  mlir/test/IR/invalid-ops.mlir
  mlir/test/IR/invalid.mlir
  mlir/test/IR/locations.mlir
  mlir/test/IR/memory-ops.mlir
  mlir/test/IR/opaque_locations.mlir
  mlir/test/IR/parser.mlir
  mlir/test/IR/pretty-locations.mlir
  mlir/test/IR/print-op-local-scope.mlir
  mlir/test/Transforms/Vectorize/compose_maps.mlir
  mlir/test/Transforms/Vectorize/normalize_maps.mlir
  mlir/test/Transforms/Vectorize/vectorize_1d.mlir
  mlir/test/Transforms/Vectorize/vectorize_2d.mlir
  mlir/test/Transforms/Vectorize/vectorize_3d.mlir
  mlir/test/Transforms/Vectorize/vectorize_outer_loop_2d.mlir
  mlir/test/Transforms/Vectorize/vectorize_outer_loop_transpose_2d.mlir
  mlir/test/Transforms/Vectorize/vectorize_transpose_2d.mlir
  mlir/test/Transforms/affine-data-copy.mlir
  mlir/test/Transforms/affine-loop-invariant-code-motion.mlir
  mlir/test/Transforms/canonicalize.mlir
  mlir/test/Transforms/constant-fold.mlir
  mlir/test/Transforms/cse.mlir
  mlir/test/Transforms/dma-generate.mlir
  mlir/test/Transforms/loop-fusion-slice-computation.mlir
  mlir/test/Transforms/loop-fusion.mlir
  mlir/test/Transforms/loop-invariant-code-motion.mlir
  mlir/test/Transforms/loop-tiling.mlir
  mlir/test/Transforms/lower-affine.mlir
  mlir/test/Transforms/memref-bound-check.mlir
  mlir/test/Transforms/memref-dataflow-opt.mlir
  mlir/test/Transforms/memref-dependence-check.mlir
  mlir/test/Transforms/memref-normalize.mlir
  mlir/test/Transforms/pipeline-data-transfer.mlir
  mlir/test/Transforms/simplify-affine-structures.mlir
  mlir/test/Transforms/slicing-utils.mlir
  mlir/test/Transforms/strip-debuginfo.mlir
  mlir/test/Transforms/unroll-jam.mlir
  mlir/test/Transforms/unroll.mlir
  mlir/test/mlir-cpu-runner/linalg_integration_test.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72429.236941.patch
Type: text/x-patch
Size: 355874 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200109/8b4a4364/attachment-0001.bin>