[PATCH] D72422: [AArch64][GlobalISel] Implement selection of <2 x float> vector splat.

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 16:42:22 PST 2020


paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:3694
+      else
+        Opc = AArch64::DUPv4i32lane;
+      break;
----------------
Would it make sense to assert that there are 4 elements?


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:3707
+      else
+        Opc = AArch64::DUPv4i32gpr;
+      break;
----------------
Same here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72422/new/

https://reviews.llvm.org/D72422





More information about the llvm-commits mailing list