[PATCH] D72425: [OptRemark] RFC: Introduce a message table for OptRemarks
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 8 16:24:07 PST 2020
hfinkel added a comment.
I like this general idea; couple of thoughts...
1. Clang has a similar system, and one disadvantage is that any time you change/add any message, it seems to trigger a large rebuild. Could we have this TG system generate separate .inc files for each category of things, so we don't have the same kind of rebuild problem.
2. Given that are arguments are named, can we use something like `"Format string with optional specifier like %{NV}"` instead of `"Format string with optional specifier like %0"`? I think that the former would be better.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72425/new/
https://reviews.llvm.org/D72425
More information about the llvm-commits
mailing list