[PATCH] D72043: [mlir] Update the CallGraph for nested symbol references, and simplify CallableOpInterface

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar marked an inline comment as done.
jpienaar added a comment.
This revision is now accepted and ready to land.
Herald added subscribers: lucyrfox, mgester, arpith-jacob.

LG, thanks



================
Comment at: mlir/lib/Analysis/CallGraph.cpp:79
+  if (CallOpInterface call = dyn_cast<CallOpInterface>(op)) {
+    // If there is no parent node, we ignore this operation. Even if this
+    // operation was a call, there would be no callgraph node to attribute it
----------------
I'm trying to think when that would even happen where we aren't in some weird state, but can't, but also not sure it would be an error state so just skipping seems fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72043/new/

https://reviews.llvm.org/D72043