[PATCH] D72379: [mlir] Canonicalize static alloc followed by memref_cast and std.view
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 8 12:04:47 PST 2020
rriddle added inline comments.
================
Comment at: mlir/test/Transforms/canonicalize.mlir:739
+ // Test: folding static alloc and memref_cast into a view.
+ // CHECK: std.view %0[][%c15, %c7] : memref<2048xi8> to memref<?x?xf32>
+ %6 = memref_cast %0 : memref<2048xi8> to memref<?xi8>
----------------
rriddle wrote:
> Don't check SSA names directly, they are not preserved.
>
> https://mlir.llvm.org/getting_started/TestingGuide/
You didn't fix this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72379/new/
https://reviews.llvm.org/D72379
More information about the llvm-commits
mailing list