[PATCH] D72400: [MLIR] Add OpenMP dialect with barrier operation

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 11:45:42 PST 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:19
+
+static DialectRegistration<OpenMPDialect> openmpDialect;
+
----------------
jdoerfert wrote:
> rriddle wrote:
> > nit: openMPDialect?
> If we spell out OpenMP it should be `OpenMP`.
MLIR uses `camelCase` variable names.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72400/new/

https://reviews.llvm.org/D72400





More information about the llvm-commits mailing list