[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 11:08:51 PST 2020


ychen added a comment.

In D72404#1810489 <https://reviews.llvm.org/D72404#1810489>, @pcc wrote:

> This is going in the wrong direction IMO. We already have a way of specifying the size optimization level, which is to specify -Os or -Oz at compile time. Why is that not sufficient?


Thanks for the quick feedback, @pcc. :-) I saw your comments somewhere on this.
I don't know why is this changing directions. It only gives the user choice to optimize for size at link stage.
They still have the freedom the do this at compile stage.

>From user perspective, if O1 <https://reviews.llvm.org/owners/package/1/>, O2 <https://reviews.llvm.org/owners/package/2/> etc. are valid options for linker stage,
I don't see a reason Os and Oz can not be used or not do the right thing.

With ThinLTO, many decisions are postponed til linker stage to have more flexibility. I guess this is one of them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72404/new/

https://reviews.llvm.org/D72404





More information about the llvm-commits mailing list