[PATCH] D72379: [mlir] Canonicalize static alloc followed by memref_cast and std.view

[Ahmed S. Taei via Phabricator via llvm-commits]

asaadaldien marked 4 inline comments as done.
asaadaldien added inline comments.


================
Comment at: mlir/lib/Dialect/StandardOps/Ops.cpp:2546
+
+    auto newOperands = {viewOp.getOperands()[1], viewOp.getOperands()[2]};
+
----------------
rriddle wrote:
> Can you use named accessors for these instead?
> 
> Also, initializer_list is a temporary so this is likely to break. Use an array instead, or inline this into the 'replace' call below.
used ViewOp::operands instead apparently its variadic  operands only


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72379/new/

https://reviews.llvm.org/D72379