[PATCH] D71904: [mlir] GPU: introduce utilities for promotion to workgroup memory

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 10:40:14 PST 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp:142
+  assert(fromType.getShape() == toType.getShape());
+  assert(fromType.getRank() != 0);
+  assert(has_single_element(region) &&
----------------
Can you add a message to this assert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71904/new/

https://reviews.llvm.org/D71904





More information about the llvm-commits mailing list