[PATCH] D71040: [ThinLTO/WPD] Fix index-based WPD for alias vtables

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 10:21:26 PST 2020


aganea added a comment.

I've used this patch since you've published it, on different contexts, things look good from my user perspective.



================
Comment at: llvm/test/ThinLTO/X86/Inputs/devirt_alias.ll:1
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-grtev4-linux-gnu"
----------------
Do you think you can add a repro for creating this input file? It's not always trivial if changes are needed further down the line.


================
Comment at: llvm/test/ThinLTO/X86/devirt_alias.ll:25
+
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-grtev4-linux-gnu"
----------------
Same comment as for the other file above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71040/new/

https://reviews.llvm.org/D71040





More information about the llvm-commits mailing list