[PATCH] D72327: Fix compiler extension builds

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:897
-        file(APPEND "${CMAKE_BINARY_DIR}/include/llvm/Support/Extension.def.tmp" "HANDLE_EXTENSION(${llvm_extension_project})\n")
-
-        get_property(llvm_plugin_targets GLOBAL PROPERTY LLVM_PLUGIN_TARGETS)
----------------
[nit] accidental whitespace change


================
Comment at: llvm/examples/Bye/CMakeLists.txt:2
+if(LLVM_BYE_LINK_INTO_TOOLS)
+  message(WARNING "Setting LLVM_BYE_LINK_INTO_TOOLS=ON only makes sense for testing purpose")
 endif()
----------------
The message could be more specific about this is not good, something like "Release build contains example code for development".

Recently we had a [[ http://lists.llvm.org/pipermail/llvm-dev/2019-October/136159.html | discussion  ]] about adding tutorial pass code to the repository, and how to include it into the build system, where D61446 came up as well. We should at some point agree how to handle example/tutorial code in release builds.

[suggestion] Only print the warning in release builds, maybe by checking CMAKE_BUILD_TYPE or LLVM_ENABLE_ASSERTIONS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72327/new/

https://reviews.llvm.org/D72327