[PATCH] D72324: [LV] Still vectorise when tail-folding can't find a primary inducation variable

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 05:23:05 PST 2020


SjoerdMeijer updated this revision to Diff 236797.
SjoerdMeijer added a comment.

Thanks for looking at this! And also for encouraging me to look at this (my own) spaghetti logic again. But to be fair, we have quite a few factors that play a role here: optimising for minsize takes precedence over the prefer predicate options, which take precedence over the loop hints, which take precedence over the TTI hook. I have explained this in the comments, and have reshuffled the logic accordingly. I am now bailing earlier on `PredicateOptDisabled`, as you suggested, loop hints need to be checked lastly, and thus this addresses your comments, I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72324/new/

https://reviews.llvm.org/D72324

Files:
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/test/Transforms/LoopVectorize/ARM/tail-folding-counting-down.ll
  llvm/test/Transforms/LoopVectorize/tail-folding-counting-down.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72324.236797.patch
Type: text/x-patch
Size: 8877 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200108/e29f8bfd/attachment.bin>


More information about the llvm-commits mailing list