[PATCH] D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 02:34:26 PST 2020


jhenderson added a comment.

In D72313#1809709 <https://reviews.llvm.org/D72313#1809709>, @TH3CHARLie wrote:

> In D72313#1809694 <https://reviews.llvm.org/D72313#1809694>, @jhenderson wrote:
>
> > Assuming the tests all pass, LGTM, thanks! Do you have commit access yet?
>
>
> Thanks for the review! All tests passed and I've recently gained commit access and want to try to commit this. If there's nothing else, I will commit this


Great, good luck! Only thing I would say is to make sure to not forget to include "Differential Revision: https://reviews.llvm.org/D72313" as a line in your commit message so that this review gets auto-closed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72313/new/

https://reviews.llvm.org/D72313





More information about the llvm-commits mailing list