[PATCH] D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 8 01:26:37 PST 2020
jhenderson added inline comments.
================
Comment at: llvm/test/tools/llvm-symbolizer/invalid-input-address.test:3
# simply echoes it as per other malformed input addresses.
-RUN: llvm-symbolizer --obj=addr.exe 0x10000000000000000 | FileCheck %s
+RUN: llvm-symbolizer --obj=addr.exe 0x10000000000000000 | FileCheck -check-prefix=LARGE-ADDR %s
----------------
Could you change this to "--check-prefix" instead of "-check-prefix" whilst you're here, please? Same comment applies throughout the test.
================
Comment at: llvm/test/tools/llvm-symbolizer/invalid-input-address.test:17
+
+LLVM-BAD-INPUT: some text
+LLVM-BAD-INPUT-NEXT: some text2
----------------
Nit: add some spaces here, so that it lines up with the check below, like the LARGE-ADDR case:
```
LLVM-BAD-INPUT: some text
LLVM-BAD-INPUT-NEXT: some text2
```
================
Comment at: llvm/test/tools/llvm-symbolizer/invalid-input-address.test:25-26
+
+GNU-BAD-INPUT: some text
+GNU-BAD-INPUT-NEXT: some text2
----------------
This was silly of me, sorry, I should have noticed earlier - you don't need separate CHECK sets for llvm-symbolizer and llvm-addr2line, because they test the same things:
Here's what I'd recommend:
```
RUN: llvm-symbolizer ... | FileCheck %s --check-prefix=BAD-INPUT
# <other llvm-symbolizer cases>
RUN: llvm-addr2line ... | FileCheck %s --check-prefix=BAD-INPUT
# <other llvm-addr2line cases>
BAD-INPUT: ...
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72313/new/
https://reviews.llvm.org/D72313
More information about the llvm-commits
mailing list