[PATCH] D72360: [Test] Make llvm and lld tests pass when $USER matches `bar`

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test:6
 # RUN: llvm-objcopy -j .other.section %t.o %t2.o
-# RUN: llvm-readobj --symbols %t2.o | FileCheck %s --implicit-check-not=bar
+# RUN: llvm-readobj --symbols %t2.o | FileCheck %s --check-prefix=NOBAR
+
----------------
rupprecht wrote:
> Read from stdin to avoid the filename showing up, e.g.
> 
> ```
> # RUN: llvm-readobj --symbols < %t2.o | FileCheck %s --implicit-check-not=bar
> ```
> 
> Then the rest of the test can remain unchanged
This will collide with D72357. As noted in that review, I'd prefer just changing the patterns to "Name: bar" (e.g. `--implicit-check-not="Name: bar"`).


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/tail-merged-string-tables.test:7-8
 ## Sanity check that the strings have been pooled.
 # RUN: llvm-readobj %t.o --string-dump .strtab --string-dump .shstrtab \
-# RUN:   | FileCheck %s --check-prefix=VALIDATE --implicit-check-not=bar --implicit-check-not=.blag
+# RUN:   | FileCheck %s --check-prefix=VALIDATE
 
----------------
rupprecht wrote:
> Same here, read from stdin
See my above comment/comment in D72357.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72360/new/

https://reviews.llvm.org/D72360