[PATCH] D72303: [BranchAlign] Compiler support for suppressing branch align

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 00:50:45 PST 2020


skan added inline comments.


================
Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1149
+  MCStreamer &OS;
+  bool OldAllowAutoPadding;
+  NoAutoPaddingScope(MCStreamer &OS)
----------------
The `OldAllowAutoPadding` is immutable indeed. I recommend declaring is as a const member and intializing it the initialization list.
Also, have your considered using the name `DefaultAllowAutoPadding`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72303/new/

https://reviews.llvm.org/D72303





More information about the llvm-commits mailing list