[PATCH] D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls
Shiva Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 7 21:29:26 PST 2020
shiva0217 accepted this revision.
shiva0217 added a comment.
This revision is now accepted and ready to land.
LGTM, Labels required to describe call site scope will be generated for the calls after FrameSetup instructions. When the SaveLibcall mark as FrameSetup, the Label will not be generated, so constructing call site entry for SaveLibcall will trigger an assertion. Given that SaveLibcall should be part of the prologue, so I think generating call site begin after FrameSetup instructions should be reasonable. But I hope there could be a second look.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71593/new/
https://reviews.llvm.org/D71593
More information about the llvm-commits
mailing list