[PATCH] D72303: [BranchAlign] Compiler support for suppressing branch align

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/X86/align-branch-boundary-noautopadding.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -verify-machineinstrs -O3 -mcpu=skylake -x86-align-branch-boundary=32 -x86-align-branch=call -filetype=obj < %s | llvm-objdump -d --no-show-raw-insn - | FileCheck %s
----------------
reames wrote:
> MaskRay wrote:
> > This should be unnecessary.
> What specifically?
Delete `; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py`

This is a hand-written test file.


================
Comment at: llvm/test/CodeGen/X86/align-branch-boundary-noautopadding.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -verify-machineinstrs -O3 -mcpu=skylake -x86-align-branch-boundary=32 -x86-align-branch=call -filetype=obj < %s | llvm-objdump -d --no-show-raw-insn - | FileCheck %s
+
----------------
reames wrote:
> MaskRay wrote:
> > Make `llvm-objdump | FileCheck` a separate step.
> > 
> > Add a separate assembly output test, checking `#noautopadding` is emitted.
> I'd really prefer not to introduce a temporary file here.  It adds no value.
> 
> Happy to add the textual assembly check.
> I'd really prefer not to introduce a temporary file here. It adds no value.

OK. No strong opinion here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72303/new/

https://reviews.llvm.org/D72303