[PATCH] D72292: [mlir] NFC: Move the state for managing aliases out of ModuleState and into a new class AliasState.

[River Riddle via Phabricator via llvm-commits]

rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/lib/IR/AsmPrinter.cpp:171
+  /// Return a name used for an attribute alias, or empty if there is no alias.
+  Twine getAttributeAlias(Attribute attr) const;
 
----------------
antiagainst wrote:
> Using Twine is kinda dangerous. Do we really need it here?
This is refactoring existing code, but I'll look into removing the twine in a followup. It is useful here to avoid allocating memory for the string in the failure(the common) case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72292/new/

https://reviews.llvm.org/D72292