[PATCH] D71978: [RISCV] Fix evalutePCRelLo for symbols at the end of a fragment

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 17:32:25 PST 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

> the approach that's here has proved sufficient in all the cases we can come up with

I'm still sort of concerned we silently miscompile when the addi is in a different fragment from the auipc, but maybe that doesn't matter much in practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71978/new/

https://reviews.llvm.org/D71978





More information about the llvm-commits mailing list