[PATCH] D72336: [mlir] Create a gpu.module operation for the GPU Dialect.

[River Riddle via Phabricator via llvm-commits]

rriddle requested changes to this revision.
rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/GPU/GPUOps.td:587
 
+
+
----------------
Why are there extra newlines here?


================
Comment at: mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.td:3
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
----------------
LLVM -> MLIR


================
Comment at: mlir/lib/Dialect/GPU/IR/GPUDialect.cpp:813
+
+void GpuModuleOp::build(Builder *builder, OperationState &result,
+                        StringRef name) {
----------------
nit: GpuModuleOp -> GPUModuleOp



================
Comment at: mlir/lib/Dialect/GPU/IR/GPUDialect.cpp:822
+  OperationState state(loc, getOperationName());
+  Builder builder(loc->getContext());
+  GpuModuleOp::build(&builder, state, name);
----------------
Why is this method necessary?


================
Comment at: mlir/lib/Dialect/GPU/IR/GPUDialect.cpp:850
+  p << op.getOperationName();
+  p << ' ';
+  p.printSymbolName(op.getName());
----------------
nit: Merge this with the line above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72336/new/

https://reviews.llvm.org/D72336