[llvm] f90a2c2 - [docs] Improve HowTo commit changes from git

Jim Lin via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 17:45:23 PST 2020


Author: Jim Lin
Date: 2020-01-08T09:48:01+08:00
New Revision: f90a2c2d2cdb679cb38400408ac5e26bea65fd14

URL: https://github.com/llvm/llvm-project/commit/f90a2c2d2cdb679cb38400408ac5e26bea65fd14
DIFF: https://github.com/llvm/llvm-project/commit/f90a2c2d2cdb679cb38400408ac5e26bea65fd14.diff

LOG: [docs] Improve HowTo commit changes from git

Summary: As a novice here I tried to `git push` my changes for a while before figuring out the correct workflow which is described on other pages. This small change doesn't reduce redundancy between those pages, but at least readers can follow the links now.

Reviewers: Kokan, Jim

Reviewed By: Kokan, Jim

Subscribers: riccibruno, kiszk, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72077

Added: 
    

Modified: 
    llvm/docs/GettingStarted.rst

Removed: 
    


################################################################################
diff  --git a/llvm/docs/GettingStarted.rst b/llvm/docs/GettingStarted.rst
index 086ae80d4b19..6dfca656d435 100644
--- a/llvm/docs/GettingStarted.rst
+++ b/llvm/docs/GettingStarted.rst
@@ -491,7 +491,11 @@ For developers to commit changes from Git
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 Once a patch is reviewed, you should rebase it, re-test locally, and commit the
-changes to LLVM's master branch. This is done using `git push`.
+changes to LLVM's master branch. This is done using `git push` if you have the
+required access rights. See `committing a change
+<Phabricator.html#committing-a-change>`_ for Phabricator based commits or
+`Developer Policy <DeveloperPolicy.html#obtaining-commit-access>`_ for commit
+access.
 
 LLVM currently has a linear-history policy, which means that merge commits are
 not allowed. The `llvm-project` repo on github is configured to reject pushes


        


More information about the llvm-commits mailing list