[PATCH] D72031: [Scheduling] Create the missing dependency edges for store cluster

[qshanz via Phabricator via llvm-commits]

steven.zhang marked an inline comment as done.
steven.zhang added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1598
+        // do not need to be copied from SUa to SUb since no one will depend
+        // on stores.
+        for (const SDep &Pred : SUb->Preds) {
----------------
fhahn wrote:
> I may be missing something, but IIRC stores could have other memory operations as successors, e.g. because to enforce an ordering between aliasing memory operations.
It they have memory dependency, they won't be put into the same group. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72031/new/

https://reviews.llvm.org/D72031