[PATCH] D71143: [ELF][Hexagon] Add support for TLS IE relocations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/hexagon-tls-ie.s:5
+# RUN: ld.lld %t.o -o %t
+# shared needs -z notext because of the R_HEX_IE_16/32_X(R_GOT) static
+# relocations
----------------
`## ` for comments.


================
Comment at: lld/test/ELF/hexagon-tls-ie.s:7
+# relocations
+# RUN: ld.lld -z notext -shared %t.o -o %t2
+# RUN: llvm-objdump -d --print-imm-hex %t | FileCheck %s
----------------
`%t.so` for shared objects.

Users expect  `%t.o` and `%t.so` to be related, so don't add `2` suffix.


================
Comment at: lld/test/ELF/hexagon-tls-ie.s:8
+# RUN: ld.lld -z notext -shared %t.o -o %t2
+# RUN: llvm-objdump -d --print-imm-hex %t | FileCheck %s
+# RUN: llvm-objdump -d --section=.got %t | FileCheck -check-prefix=CHECK-GOT %s
----------------
no-show-raw-insn to disable hex pairs in llvm-objdump -d output


================
Comment at: lld/test/ELF/hexagon-tls-ie.s:33
+# Verify that the .got entries are created.
+# CHECK-GOT: 000301a4 .got:
+# CHECK-GOT-NEXT:    301a4:	f0 ff ff ff	fffffff0 <unknown>
----------------
`llvm-readelf -x .got` to test .got . See `riscv-tls-ie.s`


================
Comment at: lld/test/ELF/hexagon-tls-ie.s:61
+
+# RELA:    0x203C4 R_HEX_TPREL_32 a 0x0
+# RELA-NEXT:    0x203C8 R_HEX_TPREL_32 b 0x0
----------------
align


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71143/new/

https://reviews.llvm.org/D71143