[PATCH] D71904: [mlir] GPU: introduce utilities for promotion to workgroup memory

[River Riddle via Phabricator via llvm-commits]

rriddle marked an inline comment as done.
rriddle added inline comments.


================
Comment at: mlir/lib/IR/Block.cpp:192
+  auto arg = BlockArgument::create(type, this);
+  arguments.insert(std::next(arguments.begin(), distance), arg);
+  return arg;
----------------
ftynse wrote:
> rriddle wrote:
> > Why can you not use it directly?
> Use what? `args_iterator` and `arguments.begin()` iterate through different things.
(Sorry, I meant 'it') Ahh yeah, I forgot about that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71904/new/

https://reviews.llvm.org/D71904