[PATCH] D72360: [Test] Make llvm and lld tests pass when $USER matches `bar`

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 13:46:57 PST 2020


rupprecht added a comment.

I left similar comments on D72357 <https://reviews.llvm.org/D72357> too



================
Comment at: lld/test/COFF/start-lib.ll:26
 ; TEST2-NOT: Name: foo
-; TEST2: bar
+; TEST2: {{[[:<:]]bar}}
 ; TEST2-NOT: Name: foo
----------------
I'm not sure what this is supposed to be. Can it just be `Name: bar`? Ditto for `TEST3-NOT` below


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test:6
 # RUN: llvm-objcopy -j .other.section %t.o %t2.o
-# RUN: llvm-readobj --symbols %t2.o | FileCheck %s --implicit-check-not=bar
+# RUN: llvm-readobj --symbols %t2.o | FileCheck %s --check-prefix=NOBAR
+
----------------
Read from stdin to avoid the filename showing up, e.g.

```
# RUN: llvm-readobj --symbols < %t2.o | FileCheck %s --implicit-check-not=bar
```

Then the rest of the test can remain unchanged


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/tail-merged-string-tables.test:7-8
 ## Sanity check that the strings have been pooled.
 # RUN: llvm-readobj %t.o --string-dump .strtab --string-dump .shstrtab \
-# RUN:   | FileCheck %s --check-prefix=VALIDATE --implicit-check-not=bar --implicit-check-not=.blag
+# RUN:   | FileCheck %s --check-prefix=VALIDATE
 
----------------
Same here, read from stdin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72360/new/

https://reviews.llvm.org/D72360





More information about the llvm-commits mailing list