[PATCH] D72230: [NFCI][LoopUnrollAndJam] Changing LoopUnrollAndJamPass to a function pass.
Whitney Tsang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 7 13:08:28 PST 2020
Whitney added a comment.
In D72230#1808620 <https://reviews.llvm.org/D72230#1808620>, @dmgreen wrote:
> If UnJ needs loops in LoopSimplify form then it should request (or enforce) that loops are in that form. I think it can be done with `AU.addRequiredID(LoopSimplifyID);` (and maybe a DEPENDENCY on LoopSimplify?) That should hopefully mean that the tests don't need these adjustments.
I am not familiar with `addRequiredID`, do you know if there is an equivalent in the new pass manager?
> Do we have any tests for the new pass manager? I feel we would have added some, but I don't see any here.
I don't see any LIT tests using the new pass manager in `llvm/test/Transforms/LoopUnrollAndJam`, is it in some other folder I missed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72230/new/
https://reviews.llvm.org/D72230
More information about the llvm-commits
mailing list