[PATCH] D72358: [llvm-objcopy][test] Fix tests when path contains "bar"

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
Herald added subscribers: llvm-commits, abrachet, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.
MaskRay added a reviewer: jlebar.

Tests that use --implicit-check-not=bar should be improved to not make jlebar sad.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72358

Files:
  llvm/test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test
  llvm/test/tools/llvm-objcopy/ELF/tail-merged-string-tables.test


Index: llvm/test/tools/llvm-objcopy/ELF/tail-merged-string-tables.test
===================================================================
--- llvm/test/tools/llvm-objcopy/ELF/tail-merged-string-tables.test
+++ llvm/test/tools/llvm-objcopy/ELF/tail-merged-string-tables.test
@@ -5,12 +5,13 @@
 # RUN: yaml2obj %s -o %t.o
 ## Sanity check that the strings have been pooled.
 # RUN: llvm-readobj %t.o --string-dump .strtab --string-dump .shstrtab \
-# RUN:   | FileCheck %s --check-prefix=VALIDATE --implicit-check-not=bar --implicit-check-not=.blag
+# RUN:   | FileCheck %s --check-prefix=VALIDATE --implicit-check-not='] bar' --implicit-check-not=.blag
 
-# VALIDATE: String dump of section '.strtab':
-# VALIDATE: bazfoobar
-# VALIDATE: String dump of section '.shstrtab':
-# VALIDATE: .blam.blah.blag
+# VALIDATE:      String dump of section '.strtab':
+# VALIDATE-NEXT: [     1] bazfoobar
+# VALIDATE-EMPTY:
+# VALIDATE-NEXT: String dump of section '.shstrtab':
+# VALIDATE-NEXT: [     1] .blam.blah.blag
 
 ## Case 1: Basic copy.
 # RUN: llvm-objcopy %t.o %t.copy
@@ -57,7 +58,7 @@
 ## Case 5: Remove symbol.
 # RUN: llvm-objcopy %t.o %t.remove-symbol -N foobar
 # RUN: llvm-readobj --symbols %t.remove-symbol \
-# RUN:   | FileCheck %s --check-prefix=REMOVE-SYMBOL --implicit-check-not foobar
+# RUN:   | FileCheck %s --check-prefix=REMOVE-SYMBOL --implicit-check-not='Name: foobar'
 
 # REMOVE-SYMBOL: Symbols [
 # REMOVE-SYMBOL:   Name: bar (
Index: llvm/test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test
===================================================================
--- llvm/test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test
+++ llvm/test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test
@@ -3,12 +3,13 @@
 
 # RUN: yaml2obj --docnum=1 %s -o %t.o
 # RUN: llvm-objcopy -j .other.section %t.o %t2.o
-# RUN: llvm-readobj --symbols %t2.o | FileCheck %s --implicit-check-not=bar
+# RUN: llvm-readobj --symbols %t2.o | FileCheck %s
 
 # RUN: llvm-objcopy -j .text -j .rela.text1 %t.o %t2.o
 # RUN: llvm-readobj --symbols %t2.o | FileCheck %s --check-prefix=BAR
 
-# BAR: bar
+# CHECK-NOT: Name: bar
+# BAR: Name: bar
 
 --- !ELF
 FileHeader:
@@ -43,7 +44,7 @@
 
 # RUN: yaml2obj --docnum=2 %s -o %t.o
 # RUN: llvm-objcopy -j .keep_me %t.o %t2.o
-# RUN: llvm-readobj --symbols %t2.o | FileCheck %s --implicit-check-not=bar
+# RUN: llvm-readobj --symbols %t2.o | FileCheck %s
 
 --- !ELF
 FileHeader:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72358.236668.patch
Type: text/x-patch
Size: 2439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200107/330dd7a2/attachment.bin>