[PATCH] D72341: [FPEnv][WIP] Fix chain handling for fpexcept.strict nodes

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1083
+                         PendingConstrainedFPStrict.size());
+  PendingExports.insert(PendingExports.end(),
+                        PendingConstrainedFPStrict.begin(),
----------------
Can we just use PendingExports.append here? I think it will take care of the reserve. I think even insert will probably take care of the reserve. Might make sense for the code in getRoot() too unless you're concerned about 2 reserves in 2 separate append calls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72341/new/

https://reviews.llvm.org/D72341