[PATCH] D72351: [AArch64][GlobalISel] Fold a chain of two G_PTR_ADDs of constant offsets.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:1356
+  Register Imm1 = MI.getOperand(2).getReg();
+  auto MaybeImmVal = getConstantVRegVal(Imm1, MRI);
+  if (!MaybeImmVal)
----------------
Why not `getConstantVRegValWithLookThrough`?


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:1366
+  Register Imm2 = Add2Def->getOperand(2).getReg();
+  auto MaybeImm2Val = getConstantVRegVal(Imm2, MRI);
+  if (!MaybeImm2Val)
----------------
Why not `getConstantVRegValWithLookThrough`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72351/new/

https://reviews.llvm.org/D72351