[PATCH] D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 10:05:32 PST 2020


daltenty created this revision.
daltenty added reviewers: DiggerLin, jasonliu, hubert.reinterpretcast.
Herald added subscribers: llvm-commits, jsji, kbarton, hiraditya, nemanjai.
Herald added a project: LLVM.
daltenty retitled this revision from "[NFC][XCOFF] Refactor CSect creation into TargetLoweringObjectFile" to "[NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile".
Herald added a subscriber: wuzish.

We create a number of standard types of control sections in multiple places for
things like the function descriptors, external references and the TOC anchor
among others, so it is possible for  their properties to be defined
inconsistently in different places. This refactor moves their creation and
properties into functions in the TargetLoweringObjectFile class hierarchy, where
functions for retrieving various special types of sections typically seem
to reside.

Note: There is one case in PPCISelLowering which is specific to function entry 
points which we don't address since we don't have access to the TLOF there.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72347

Files:
  llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/include/llvm/Target/TargetLoweringObjectFile.h
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72347.236623.patch
Type: text/x-patch
Size: 12435 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200107/729b3847/attachment.bin>


More information about the llvm-commits mailing list