[PATCH] D71870: [llvm-locstats] Add the --compare option

[David Stenberg via Phabricator via llvm-commits]

dstenb added a comment.

Some nits.



================
Comment at: llvm/utils/llvm-locstats/llvm-locstats.py:123
+    ax.bar(buckets, self.variables_coverage_map.values(), align='edge',
+           tick_label=self.variables_coverage_map.keys(), width = 0.4,
+           label='variables of {}'.format(self.file_name))
----------------
spaces around equals for the `width` parameter.


================
Comment at: llvm/utils/llvm-locstats/llvm-locstats.py:127
+           locstats_to_compare.variables_coverage_map.values(),
+           color='r', align='edge', width = -0.4,
+           tick_label=locstats_to_compare.variables_coverage_map.keys(),
----------------
spaces around equals for the `width` parameter.


================
Comment at: llvm/utils/llvm-locstats/llvm-locstats.py:331
+    locstats_to_compare = parse_locstats(opts, binary_file_to_compare)
+    # Draw a plot whoing the difference in debug location coverage between
+    # two files.
----------------
whoing -> showing ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71870/new/

https://reviews.llvm.org/D71870