[PATCH] D70913: [FPEnv][SelectionDAG] Relax chain requirements

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 08:59:01 PST 2020


uweigand added a comment.

In D70913#1802960 <https://reviews.llvm.org/D70913#1802960>, @uweigand wrote:

> I guess you're right -- the current behavior seems correct only for fpexcept.maytrap but not fpexcept.strict nodes.  The latter need to be part of both getRoot and getControlRoot.  I'm not sure whether simply adding the nodes to both PendingLoads and PendingExports will work though, since then we might get duplicate chain links ... we may need a seperate list for the FP nodes.  I'll have a look.


See D72341 <https://reviews.llvm.org/D72341>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70913/new/

https://reviews.llvm.org/D70913





More information about the llvm-commits mailing list