[PATCH] D72327: Fix compiler extension builds

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:850-853
 # add_llvm_pass_plugin(name)
 #   Add ${name} as an llvm plugin.
 #   If option LLVM_${name_upper}_LINK_INTO_TOOLS is set to ON, the plugin is registered statically.
 #   Otherwise a pluggable shared library is registered.
----------------
[doc] Document the NO_MODULE option


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:865
+    # In a static build, BUILDTREE_ONLY is irrelevant
+	list(REMOVE_ITEM ARG_UNPARSED_ARGUMENTS BUILDTREE_ONLY)
+    # process_llvm_pass_plugins takes care of the actual linking, just create an
----------------
[nit] indention


================
Comment at: llvm/examples/Bye/CMakeLists.txt:1
-add_llvm_pass_plugin(Bye
+if(LLVM_BUILD_EXAMPLES)
+  add_llvm_pass_plugin(Bye
----------------
[serious] Whether example targets are generated is controlled by `LLVM_INCLUDE_EXAMPLES`. `LLVM_BUILD_EXAMPLES` should control `EXCLUDE_FROM_ALL` or similar. Is there a corresponding option for pass plugins, especially if `LLVM_BYE_LINK_INTO_TOOLS` is off?

I'd assume that if `LLVM_BUILD_EXAMPLES` is off, but `LLVM_BYE_LINK_INTO_TOOLS` is on, that latter would effectively override `EXCLUDE_FROM_ALL` since the plugin is needed to built opt,bugpoint,etc.

Btw, what is the "Fix validation issue when building examples"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72327/new/

https://reviews.llvm.org/D72327