[PATCH] D72167: Add support for __declspec(guard(nocf))

Andrew Paverd via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 06:28:03 PST 2020


ajpaverd added a comment.

In D72167#1803395 <https://reviews.llvm.org/D72167#1803395>, @aaron.ballman wrote:

> Can you please add some Sema tests that verify the attribute only appertains to functions, accepts the right number of arguments, etc? Also, some tests showing how this attribute works for things like redelcarations and virtual functions would help.


Thanks for the feedback @aaron.ballman! I've added tests that should match the behaviour of MSVC for each of the cases you suggested (as well as function inlining).  Any other test cases we should add?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72167/new/

https://reviews.llvm.org/D72167





More information about the llvm-commits mailing list