[PATCH] D72129: [mlir] Add in-dialect lowering of gpu.all_reduce.

[Christian Sigg via Phabricator via llvm-commits]

csigg marked 4 inline comments as done.
csigg added inline comments.


================
Comment at: mlir/lib/Dialect/GPU/Transforms/AllReduceLowering.cpp:352
+    };
+    while (funcOp.walk(callback).wasInterrupted()) {
+    }
----------------
rriddle wrote:
> When does this ever fail?
See two lines above: every time the callback is invoked. This makes sure that all occurrences of gpu.all_reduce in the same gpu.function are replaced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72129/new/

https://reviews.llvm.org/D72129