[PATCH] D71743: [ARM][MVE] Enable masked gathers from vector of pointers
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 7 03:23:03 PST 2020
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM, if no-one else has any other comments.
================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:529
+ // - and also from the masked intrinsic lowering pass with the actual vector
+ // type. For MVE, we want to custom legalise any gathers that we can to mve
+ // intrinsics, and expand all the rest. So if we are here, we know we want
----------------
Maybe expand this a little to "For MVE, we have a custom lowering pass that will already have custom legalised any gathers that we can to mve intrinsics, and want to expand all the rest. The pass runs before the masked intrinsic lowering pass, so if we are here, we know we want to expand."
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71743/new/
https://reviews.llvm.org/D71743
More information about the llvm-commits
mailing list