[PATCH] D72180: [MC] Add parameter `Address` to MCInstrPrinter::printInstruction

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 01:12:40 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.

This change itself looks good to me. If I understand correctly from @rnk's comment, his suggestion is that there should be an option in llvm-objdump to revert to the old behaviour (which as you point it would be to just pass in 0 instead of the current address). This would mean that people used to the offset behaviour can choose to use that still. I think there is some benefit to this too, but I guess that it should actually be a change to D72172 <https://reviews.llvm.org/D72172>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72180/new/

https://reviews.llvm.org/D72180





More information about the llvm-commits mailing list