[PATCH] D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D72313#1807539 <https://reviews.llvm.org/D72313#1807539>, @TH3CHARLie wrote:

> In D72313#1807518 <https://reviews.llvm.org/D72313#1807518>, @jhenderson wrote:
>
> > Also, I think it would be good to expand `invalid-input-address.test` to cover this. In fact, you might want to put both your new case and something equivalent to the existing one in sym.test in the same place. That way, we're not lumping multiple different kinds of checks into the same test file.
>
>
> I'm not quite sure about this so I'd like to confirm my understanding again before updating. Feel free to correct me if I misunderstand this: adding new tests(instead of moving existing ones in sym.test) to `invalid-input-address.test` that checks for invalid value like the `sometext` used in sym.test. And the testcases cover command line, ordinary textual file and response file.


That's correct. It tests the three different ways you can get inputs into llvm-symbolizer (command-line, response file, stdin). You may want to include llvm-addr2line and llvm-symbolizer versions too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72313/new/

https://reviews.llvm.org/D72313