[PATCH] D72315: [NFC] Simplifying the condition which kind of MCFragment doesn't need to handle fixup

[Jim Lin via Phabricator via llvm-commits]

Jim created this revision.
Jim added a reviewer: pete.
Jim added a project: LLVM.
Herald added subscribers: llvm-commits, hiraditya.

1. MCCompactEncodedInstFragment is a subclass of MCEncodedFragment.
2. Add missing kind MCFragment::FT_CVDefRange into MCEncodedFragment's classof.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72315

Files:
  llvm/include/llvm/MC/MCFragment.h
  llvm/lib/MC/MCAssembler.cpp


Index: llvm/lib/MC/MCAssembler.cpp
===================================================================
--- llvm/lib/MC/MCAssembler.cpp
+++ llvm/lib/MC/MCAssembler.cpp
@@ -799,13 +799,9 @@
     for (MCFragment &Frag : Sec) {
       // Data and relaxable fragments both have fixups.  So only process
       // those here.
-      // FIXME: Is there a better way to do this?  MCEncodedFragmentWithFixups
-      // being templated makes this tricky.
-      if (isa<MCEncodedFragment>(&Frag) &&
-          isa<MCCompactEncodedInstFragment>(&Frag))
+      if (isa<MCCompactEncodedInstFragment>(&Frag))
         continue;
-      if (!isa<MCEncodedFragment>(&Frag) && !isa<MCCVDefRangeFragment>(&Frag) &&
-          !isa<MCAlignFragment>(&Frag))
+      if (!isa<MCEncodedFragment>(&Frag) && !isa<MCAlignFragment>(&Frag))
         continue;
       ArrayRef<MCFixup> Fixups;
       MutableArrayRef<char> Contents;
Index: llvm/include/llvm/MC/MCFragment.h
===================================================================
--- llvm/include/llvm/MC/MCFragment.h
+++ llvm/include/llvm/MC/MCFragment.h
@@ -136,6 +136,7 @@
     case MCFragment::FT_Data:
     case MCFragment::FT_Dwarf:
     case MCFragment::FT_DwarfFrame:
+    case MCFragment::FT_CVDefRange:
       return true;
     }
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72315.236515.patch
Type: text/x-patch
Size: 1277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200107/4aa0b121/attachment.bin>