[PATCH] D72170: AMDGPU/GlobalISel: Fix argument lowering for vectors of pointers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 14:35:40 PST 2020


arsenm added a comment.

In D72170#1806811 <https://reviews.llvm.org/D72170#1806811>, @paquette wrote:

> > When these arguments are broken down by the EVT based callbacks, the pointer information is lost.
>
> Is it possible to make sure that this doesn't happen generically? I assume this will be a problem for other backends at some point.


I don't like how this argument pack/unpack logic is in the target at all. This isn't really doing anything special. Currently all targets seem to be duplicating similar looking pack/unpack functions


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72170/new/

https://reviews.llvm.org/D72170





More information about the llvm-commits mailing list