[PATCH] D71860: AMDGPU/GlobalISel: Replace handling of boolean values

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 13:57:54 PST 2020


kerbowa accepted this revision.
kerbowa added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:2741
+    // SCC results will need to be copied to a 32-bit SGPR virtual register.
+    //consst unsigned ResultSize = CanUseSCC ? 32 : 1;
+    const unsigned ResultSize = 1;
----------------
NITPICK: const


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71860/new/

https://reviews.llvm.org/D71860





More information about the llvm-commits mailing list