[PATCH] D72264: GlobalISel: Implement s32->s64 G_FPTOSI lowering

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4025
+  // This algorithm comes from compiler-rt's implementation of fixsfdi:
+  // https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/builtins/fixsfdi.c
+
----------------
paquette wrote:
> Do we need the whole GitHub URL here? Why not just compiler-rt/lib/builtins/fixsfdi.c?
> 
> Also it looks like most the work is in fp_fixint_impl.inc? Would it be better to point at that instead?
Comments copied directly from the DAG version


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72264/new/

https://reviews.llvm.org/D72264