[PATCH] D71985: [NewPM] Fix -lto-debug-pass-manager in LLD.
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 6 13:20:30 PST 2020
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: llvm/lib/LTO/LTOBackend.cpp:257
// Now, add all the passes we've been requested to.
- if (auto Err = PB.parsePassPipeline(MPM, PipelineDesc))
+ if (auto Err = PB.parsePassPipeline(MPM, PipelineDesc, true, DebugPassManager))
report_fatal_error("unable to parse pass pipeline description '" +
----------------
hghwng wrote:
> MaskRay wrote:
> > `auto->Error` since you are touching this line.
> Could you please elaborate it a bit?
I think he's saying you should spell explicitly `Error Err = ...`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71985/new/
https://reviews.llvm.org/D71985
More information about the llvm-commits
mailing list