[PATCH] D71849: Don't rely on '%l' modifiers to indicate a label reference

[Bill Wendling via Phabricator via llvm-commits]

void marked an inline comment as done.
void added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:470
+                     !MI->getOperand(OpNo).isBlockAddress() &&
+                     !MI->getOperand(OpNo).isMBB()) {
+            Error = true;
----------------
nickdesaulniers wrote:
> Would you mind hoisting the expression `MI->getOperand(OpNo)` into a local variable defined above near the definition of `OpNo`? It would DRY up this code.
The compiler should do this already, because `MI` is `const` and `getOperand` has no side-effects. I think that's who no one has bothered to do it before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71849/new/

https://reviews.llvm.org/D71849