[PATCH] D72194: WIP alternative approach for D68101

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/test/CodeGen/X86/explict-section-mergeable.ll:10
+;; Check that the globals have been placed into several sections with
+;; the same name
+
----------------
```
- ;; the same name
+ ;; the same name, but different entity sizes.
```


================
Comment at: llvm/test/CodeGen/X86/explict-section-mergeable.ll:12
+
+; UNIQUE:     .section        ".clang-section-pragma","aM", at progbits,4,unique,1
+; UNIQUE-NOT: .section
----------------
I don't understand the `,unique,1` part. Can you clarify?
https://sourceware.org/binutils/docs/as/Section.html


================
Comment at: llvm/test/CodeGen/X86/explict-section-mergeable2.ll:10
+;; Check that the globals have been placed into several sections with
+;; the same name
+
----------------
ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72194/new/

https://reviews.llvm.org/D72194