[PATCH] D72002: GlobalISel: Handle llvm.read_register

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 08:58:12 PST 2020


arsenm added a comment.

In D72002#1806076 <https://reviews.llvm.org/D72002#1806076>, @rengolin wrote:

> Hi Matt,
>
> Can you foresee any additional use to selectCommon? I'm not familiar with Global Isel that much, but it feels this is easier to implement, but may not be a good long term strategy.
>
> --renato


The 3 big things SelectionDAG uses for this are in the same category. read_register, write_register and inline asm. The rest doesn't really apply. The alternative is every target needs to implement the exact same string parsing which is unneeded duplication


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72002/new/

https://reviews.llvm.org/D72002





More information about the llvm-commits mailing list