[PATCH] D71086: Let PassBuilder Expose PassInstrumentationCallbacks

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 08:34:51 PST 2020


fedor.sergeev accepted this revision.
fedor.sergeev added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/include/llvm/Passes/PassBuilder.h:635
+
+  /// Returns PIC. External libraries can use this to add pass instrumentation
+  PassInstrumentationCallbacks *getPassInstrumentationCallbacks() const {
----------------
nit:  "to add pass instrumentation" -> "to register pass instrumentation callbacks."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71086/new/

https://reviews.llvm.org/D71086





More information about the llvm-commits mailing list