[PATCH] D72249: Detemplaize m_Op and RecursivePatternMatcher.

Mon Jan 6 08:16:02 PST 2020

rriddle added inline comments.

================
Comment at: mlir/include/mlir/IR/Matchers.h:54
+template <typename AttrT>
+struct constant_op_binder {
   AttrT *bind_value;
----------------
chelini wrote:
> ftynse wrote:
> > This looks like unrelated change, and also wrong format.
> Hi Alex, thanks for the comments. I will get back to you with the fixes soon. But before I need a little clarification. I indeed run `clang-format -i ` on the entire file but I used the clang-format file in the MLIR directory. The reason why the code has been formated this way is the second line in the clang-format file: [[ https://github.com/llvm/llvm-project/blob/d67c4cc2eb4ddc450c886598b934c111e721ab0c/mlir/.clang-format#L2  | here ]]
> 
> Should I follow the standard dictates by this line or it is unwanted?
You probably want to use 'git clang-format' instead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72249/new/

https://reviews.llvm.org/D72249